[lworld] RFR: 8288135: [lworld] Implement HotSpot flag -XX:+EnablePrimitiveClasses [v10]

David Simms dsimms at openjdk.org
Tue Oct 4 08:31:18 UTC 2022


On Mon, 3 Oct 2022 14:21:22 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> David Simms has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
>> 
>>  - Merge branch 'lworld' into 8288135
>>  - Extra assertion info for tracking spurious issue
>>  - supports_inline_types() refers to classfile and is separate from Enable flags
>>  - Further testing explicity using flags
>>  - Disable EnablePrimitiveClasses by default
>>  - Explictly flag more tests
>>  - Merge branch 'lworld' into 8288135
>>  - jdk_valhalla tests
>>  - Merge branch 'lworld' into 8288135
>>  - Further test fixes
>>  - ... and 12 more: https://git.openjdk.org/valhalla/compare/951544ff...1853e0c6
>
> src/hotspot/share/classfile/classFileParser.cpp line 5235:
> 
>> 5233:       // Can't enable this check fully until JDK upgrades the bytecode generators.
>> 5234:       // For now, compare to class file version 51 so old verifier doesn't see Q signatures.
>> 5235:       if ( (_major_version < 51 /* CONSTANT_CLASS_DESCRIPTORS */ ) || (!EnablePrimitiveClasses)) {
> 
> Are there a CRs to track the changes requires in the JDK and the status of this check and its dependency to JDK updates?

I can add a reference to [JDK-8270852](https://bugs.openjdk.org/browse/JDK-8270852)

-------------

PR: https://git.openjdk.org/valhalla/pull/727



More information about the valhalla-dev mailing list