[lworld] RFR: 8288135: [lworld] Implement HotSpot flag -XX:+EnablePrimitiveClasses [v10]

[David Simms]

On Mon, 3 Oct 2022 14:30:54 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> David Simms has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
>> 
>>  - Merge branch 'lworld' into 8288135
>>  - Extra assertion info for tracking spurious issue
>>  - supports_inline_types() refers to classfile and is separate from Enable flags
>>  - Further testing explicity using flags
>>  - Disable EnablePrimitiveClasses by default
>>  - Explictly flag more tests
>>  - Merge branch 'lworld' into 8288135
>>  - jdk_valhalla tests
>>  - Merge branch 'lworld' into 8288135
>>  - Further test fixes
>>  - ... and 12 more: https://git.openjdk.org/valhalla/compare/951544ff...1853e0c6
>
> src/hotspot/share/classfile/classFileParser.cpp line 6183:
> 
>> 6181:     recognized_modifiers |= JVM_ACC_MODULE;
>> 6182:   }
>> 6183:   // Are JVM_ACC_VALUE and JVM_ACC_PRIMITIVE support (version and feature check)
> 
> JVM_ACC_PRIMITIVE should be controlled by both the value of supports_inline_types() and EnablePrimitiveClasses.

Reverted comment to "defined for class version" `// JVM_ACC_VALUE and JVM_ACC_PRIMITIVE are defined for supported version`

> test/hotspot/jtreg/runtime/valhalla/inlinetypes/classfileparser/BadACCValue.java line 27:
> 
>> 25:  * @test
>> 26:  * @summary test that if a class file has ACC_VALUE or ACC_PRIMITIVE set then it must be run
>> 27:  *          with option -XX:+ÉnableValhalla or -XX:+EnablePrimitiveClasses respectively.
> 
> Looks like there's an accent on the E of -XX:+ÉnableValhalla.

Oh yeah, nice spot

-------------

PR: https://git.openjdk.org/valhalla/pull/727