[lworld] RFR: 8294159: automatically generated tests under test/jdk/java/lang/invoke/VarHandles/ have been modified by mistake [v2]

Mandy Chung mchung at openjdk.org
Thu Sep 22 16:59:44 UTC 2022


On Thu, 22 Sep 2022 15:08:54 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Most tests under `test/jdk/java/lang/invoke/VarHandles/` should be generated from a template, that is processed by the script `generate-vh-tests.sh` located in the same folder. Several of these tests have been modified directly instead of modifying the template. This PR is correcting this issue,
>> 
>> TIA
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updating copyright date for template

test/jdk/java/lang/invoke/VarHandles/generate-vh-tests.sh line 46:

> 44:   case $type in
> 45:     Point)
> 46:       args="$args -KPrimitiveClass"

I don't think PrimitiveClass is needed.


  case $type in
    boolean|byte|short|char|int|long|float|double|Point)
      args="$args -KValue"
      ;;
  esac
```  

"Value" is used to annotate as primitive class because "value class" was the terminology when these tests were updated.

You can rename `Value` to `PrimitiveClass` in this file and `X-VarHandle*` templates.  Or leave it as is and we will change that when we add tests for value objects.

-------------

PR: https://git.openjdk.org/valhalla/pull/765



More information about the valhalla-dev mailing list