[lworld] RFR: 8294159: automatically generated tests under test/jdk/java/lang/invoke/VarHandles/ have been modified by mistake [v2]

Vicente Romero vromero at openjdk.org
Thu Sep 22 19:00:47 UTC 2022


On Thu, 22 Sep 2022 16:57:43 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updating copyright date for template
>
> test/jdk/java/lang/invoke/VarHandles/generate-vh-tests.sh line 46:
> 
>> 44:   case $type in
>> 45:     Point)
>> 46:       args="$args -KPrimitiveClass"
> 
> I don't think PrimitiveClass is needed.
> 
> 
>   case $type in
>     boolean|byte|short|char|int|long|float|double|Point)
>       args="$args -KValue"
>       ;;
>   esac
> ```  
> 
> "Value" is used to annotate as primitive class because "value class" was the terminology when these tests were updated.
> 
> You can rename `Value` to `PrimitiveClass` in this file and `X-VarHandle*` templates.  Or leave it as is and we will change that when we add tests for value objects.

well `Value` is passed as an argument for all the types above I wanted a variable that was passed only if type was Point, this is why I created a new one. Consider that there is code that is not generated if the type is `Point`

-------------

PR: https://git.openjdk.org/valhalla/pull/765



More information about the valhalla-dev mailing list