[lworld] RFR: 8315412 [lworld] Preparing code for lw5

[Lois Foltan]

On Wed, 30 Aug 2023 20:52:42 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Quite a big patch, but it is mostly made of renaming and mechanical replacement without really changing the logic of the code.
> 
> The patch includes changes to make the VM code less dependent on Q-descriptors by encoding the presence of null-free inline types fields in FieldInfo.
> 
> The patch also includes a lot of renaming, in an effort to have uniformed naming of flat fields and flat arrays across the VM. The renaming has not been applied to the heap dumper and C2. They will be addressed in follow up patches.
> 
> Tested with Mach5, tiers 1 to 3.
> 
> Thank you
> 
> Fred

Good clean up, some very minor comments, overall looks good.

src/hotspot/share/ci/ciInstanceKlass.cpp line 774:

> 772:     }
> 773:     case T_PRIMITIVE_OBJECT: // fall-through
> 774:     case T_ARRAY:  // fall-through

Minor nit: do both line 773 & 774 need "fall-through" comment?

src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 697:

> 695:  *     constraint when flattening this inline type into another container
> 696:  *   - field flattening decisions are taken in this method (those decisions are
> 697:  *     currently only based in the size of the fields to be flatten, the size

flatten -> flattened

src/hotspot/share/oops/cpCache.cpp line 136:

> 134:                   ((is_volatile ? 1 : 0) << is_volatile_shift) |
> 135:                   ((is_final    ? 1 : 0) << is_final_shift) |
> 136:                   ((is_flat  ? 1 : 0) << is_flat_shift) |

Minor nit, line up ternary expression with lines above

-------------

Marked as reviewed by lfoltan (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/922#pullrequestreview-1605471945
PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312077689
PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312066245
PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312073822