[lworld] RFR: 8315412 [lworld] Preparing code for lw5 [v2]

[Frederic Parain]

On Thu, 31 Aug 2023 18:55:38 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addresing Lois' comments
>
> src/hotspot/share/ci/ciInstanceKlass.cpp line 774:
> 
>> 772:     }
>> 773:     case T_PRIMITIVE_OBJECT: // fall-through
>> 774:     case T_ARRAY:  // fall-through
> 
> Minor nit: do both line 773 & 774 need "fall-through" comment?

The comment in the T_ARRAY case will remain even after the removal of Q-descriptor.
The comment in the T_PRIMITIVE_OBJECT case makes it much easier to see (with grep) that this case is simply going to go away after the removal of Q-descriptors.

> src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 697:
> 
>> 695:  *     constraint when flattening this inline type into another container
>> 696:  *   - field flattening decisions are taken in this method (those decisions are
>> 697:  *     currently only based in the size of the fields to be flatten, the size
> 
> flatten -> flattened

Fixed

> src/hotspot/share/oops/cpCache.cpp line 136:
> 
>> 134:                   ((is_volatile ? 1 : 0) << is_volatile_shift) |
>> 135:                   ((is_final    ? 1 : 0) << is_final_shift) |
>> 136:                   ((is_flat  ? 1 : 0) << is_flat_shift) |
> 
> Minor nit, line up ternary expression with lines above

Fixed

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312140567
PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312137715
PR Review Comment: https://git.openjdk.org/valhalla/pull/922#discussion_r1312140683