[lworld] RFR: 8321941: Migrate test/jdk/valhalla/valuetypes from primitive classes to null-restricted types

[Roger Riggs]

On Wed, 13 Dec 2023 01:28:58 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> Migrate test/jdk/valhalla/valuetypes tests to use null-restricted types instead.

test/jdk/valhalla/valuetypes/ArrayElementVarHandleTest.java line 28:

> 26:  * @test
> 27:  * @summary test VarHandle on value class array
> 28:  * @compile -XDenablePrimitiveClasses ArrayElementVarHandleTest.java

It looks like the compiler does not need -XDenablePrimitiveClasses.
Except in RecursiveValueClass.java that still has a primitive class declaration.

test/jdk/valhalla/valuetypes/ArrayElementVarHandleTest.java line 30:

> 28:  * @compile -XDenablePrimitiveClasses ArrayElementVarHandleTest.java
> 29:  * @run junit/othervm -XX:+EnableValhalla -XX:FlatArrayElementMaxSize=-1 ArrayElementVarHandleTest
> 30:  * @run testng/othervm -XX:+EnableValhalla -XX:FlatArrayElementMaxSize=0  ArrayElementVarHandleTest

junit here too?

test/jdk/valhalla/valuetypes/ObjectMethods.java line 119:

> 117:     static Stream<Arguments> identitiesData() {
> 118:         return Stream.of(
> 119:                 Arguments.of(new Object(), false, false),

The JEP doesn't say this (yet) but `new Object()` is an identity instance. java.util.Objects.isIdentityObject() and .isValueObject() will need to be updated too.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425671316
PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425624039
PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425642915