[lworld] RFR: 8321941: Migrate test/jdk/valhalla/valuetypes from primitive classes to null-restricted types [v2]

[Mandy Chung]

On Wed, 13 Dec 2023 17:26:17 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove @compile
>
> test/jdk/valhalla/valuetypes/ArrayElementVarHandleTest.java line 28:
> 
>> 26:  * @test
>> 27:  * @summary test VarHandle on value class array
>> 28:  * @compile -XDenablePrimitiveClasses ArrayElementVarHandleTest.java
> 
> It looks like the compiler does not need -XDenablePrimitiveClasses.
> Except in RecursiveValueClass.java that still has a primitive class declaration.

Updated.

> test/jdk/valhalla/valuetypes/ObjectMethods.java line 119:
> 
>> 117:     static Stream<Arguments> identitiesData() {
>> 118:         return Stream.of(
>> 119:                 Arguments.of(new Object(), false, false),
> 
> The JEP doesn't say this (yet) but `new Object()` is an identity instance. java.util.Objects.isIdentityObject() and .isValueObject() will need to be updated too.

It already handles that.  The two arguments specify if the class of the instance is identity class or value class.     The test special cases to verify if the class is `Object.class`, it's an identity object.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425713015
PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425714513