[lworld] RFR: 8321941: Migrate test/jdk/valhalla/valuetypes from primitive classes to null-restricted types [v2]

Roger Riggs rriggs at openjdk.org
Wed Dec 13 21:19:00 UTC 2023


On Wed, 13 Dec 2023 18:10:18 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Migrate test/jdk/valhalla/valuetypes tests to use null-restricted types instead.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove @compile

Marked as reviewed by rriggs (Committer).

test/jdk/valhalla/valuetypes/LambdaMetaFactory/LambdaTest.java line 26:

> 24: /*
> 25:  * @test
> 26:  * @run junit/othervm -XX:+EnableValhalla LambdaTest

Just style suggestion in the order of jtreg tags, @summary should come before @run

-------------

PR Review: https://git.openjdk.org/valhalla/pull/963#pullrequestreview-1780498389
PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425890156



More information about the valhalla-dev mailing list