[lworld] RFR: 8321941: Migrate test/jdk/valhalla/valuetypes from primitive classes to null-restricted types [v2]

Mandy Chung mchung at openjdk.org
Wed Dec 13 22:10:11 UTC 2023


On Wed, 13 Dec 2023 21:12:37 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove @compile
>
> test/jdk/valhalla/valuetypes/LambdaMetaFactory/LambdaTest.java line 26:
> 
>> 24: /*
>> 25:  * @test
>> 26:  * @run junit/othervm -XX:+EnableValhalla LambdaTest
> 
> Just style suggestion in the order of jtreg tags, @summary should come before @run

Hmm... we have a mixture of style.  The jtreg document states `@summary` comes before the action.   I will update them.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/963#discussion_r1425935340



More information about the valhalla-dev mailing list