[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v3]

[David Holmes]

On Wed, 22 Feb 2023 23:04:53 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Make copies of classes to be made value classes in src/java.base/valueclasses/classes 
>> Modify CompileJavaModules.gmk to trigger builds of values classes and construct a .jar for each module.
>> Add the jar files to $JAVA_HOME/lib/valueclasses/<module\>-valueclasses.jar 
>> 
>> Modify hotspot arguments.cpp to scan for patch jar files when --enable-preview and -XX:+EnableValhalla.
>> For each jar, the equivalent of --patch-module <module>=<path-to-jar> is added and the system properties `jdk.module.patch.<n>` include jar file paths.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced patch_mod_javabase with a check for an empty list of --patch-modules.
>   Other review comment cleanup.

src/hotspot/share/runtime/arguments.cpp line 3193:

> 3191: 
> 3192:   if (UseSharedSpaces && _patch_mod_prefix != nullptr) {
> 3193:     no_shared_spaces("CDS is disabled when any module is patched.");

But you are now disabling CDS if any module is patched, when the constraint AFAIK is only on the base module.

-------------

PR: https://git.openjdk.org/valhalla/pull/816