[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v3]

Roger Riggs rriggs at openjdk.org
Thu Feb 23 20:45:38 UTC 2023


On Thu, 23 Feb 2023 03:31:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replaced patch_mod_javabase with a check for an empty list of --patch-modules.
>>   Other review comment cleanup.
>
> src/hotspot/share/runtime/arguments.cpp line 3193:
> 
>> 3191: 
>> 3192:   if (UseSharedSpaces && _patch_mod_prefix != nullptr) {
>> 3193:     no_shared_spaces("CDS is disabled when any module is patched.");
> 
> But you are now disabling CDS if any module is patched, when the constraint AFAIK is only on the base module.

Corrected to restore previous behavior and different messages between patching java.base and any other module.

-------------

PR: https://git.openjdk.org/valhalla/pull/816



More information about the valhalla-dev mailing list