[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v5]

[David Holmes]

On Fri, 24 Feb 2023 20:41:56 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Make copies of classes to be made value classes in src/java.base/valueclasses/classes 
>> Modify CompileJavaModules.gmk to trigger builds of values classes and construct a .jar for each module.
>> Add the jar files to $JAVA_HOME/lib/valueclasses/<module\>-valueclasses.jar 
>> 
>> Modify hotspot arguments.cpp to scan for patch jar files when --enable-preview and -XX:+EnableValhalla.
>> For each jar, the equivalent of --patch-module <module>=<path-to-jar> is added and the system properties `jdk.module.patch.<n>` include jar file paths.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct indentation/space usage in makefiles.

Sorry for the delay (I don't get email notifications for this PR).

The hotspot changes are looking good.

One minor nit.

src/hotspot/share/runtime/arguments.cpp line 3027:

> 3025:       } else {
> 3026:         vm_exit_during_initialization("Cannot specify a module more than once to --patch-module", module_name);
> 3027:       }

This just reduces to:

else {
  vm_exit_during_initialization(err_msg("Cannot specify %s more than once to --patch-module", module_name));
}

or even:

vm_exit_during_initialization("Cannot specify a module more than once to --patch-module", module_name);

-------------

PR: https://git.openjdk.org/valhalla/pull/816