[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v5]

[Roger Riggs]

On Mon, 27 Feb 2023 21:32:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct indentation/space usage in makefiles.
>
> src/hotspot/share/runtime/arguments.cpp line 3027:
> 
>> 3025:       } else {
>> 3026:         vm_exit_during_initialization("Cannot specify a module more than once to --patch-module", module_name);
>> 3027:       }
> 
> This just reduces to:
> 
> else {
>   vm_exit_during_initialization(err_msg("Cannot specify %s more than once to --patch-module", module_name));
> }
> 
> or even:
> 
> vm_exit_during_initialization("Cannot specify a module more than once to --patch-module", module_name);

Right, for some reason there are several tests that expect different error messages due to the prior implementation split between hotspot argument parsing and ModuleBootstrap.
I couldn't see clearly far enough in the EA/Preview/release cycle to be sure of the final disposition and so punted on correcting everything everywhere.
Eventually, the provision to replace some classes with value classes unnecessary. The classes will become permanent.
But that can only happen after the feature is no-longer preview and is fully integrated.

-------------

PR: https://git.openjdk.org/valhalla/pull/816