RFR: 8310905: [lw5] addressing review comments on null restricted types [v4]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Jul 12 09:30:21 UTC 2023


On Wed, 5 Jul 2023 21:20:45 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> addressing some review comments related to PR [1]
>> 
>> [1] https://github.com/openjdk/valhalla/pull/872
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding more regression tests

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 786:

> 784:     }
> 785: 
> 786:     public boolean sameNullabilityAs(Type t) {

Should these methods be here or in Types, since they are general relation on types?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/880#discussion_r1260889493



More information about the valhalla-dev mailing list