RFR: 8310905: [lw5] addressing review comments on null restricted types [v4]

[Maurizio Cimadamore]

On Wed, 12 Jul 2023 09:27:41 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adding more regression tests
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 786:
> 
>> 784:     }
>> 785: 
>> 786:     public boolean sameNullabilityAs(Type t) {
> 
> Should these methods be here or in Types, since they are general relation on types?

Also, looking at all these tests I wonder it we shouldn't maybe expose the NullMarker enum directly with a single accessor, and then use that (e.g. in a switch) to do the various tests. But this is just minor code style comments, no need to block this PR (mostly thinking aloud).

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/880#discussion_r1260892322