[lworld+vector] RFR: 8307715: Integrate VectorMask/Shuffle with value/primitive classes [v2]

[Xiaohong Gong]

On Wed, 24 May 2023 08:27:06 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>>> Hi @jatin-bhateja , could you please help to run and test whether the issue you met is fixed with the latest commit? I met other regressions and am working in progress to see what is going on. Thanks a lot!
>> 
>> Hi @XiaohongGong,
>> 
>> I floated a patch to merge latest changes from lword into lworld+vector since there have been changes in InlineTypeNode IR.
>> https://github.com/openjdk/valhalla/pull/847
>> 
>> With following patch most of the JTreg tests are passing. Load/Store tests are failing because EnablePrimitiveClass not getting set with --add-modules=jdk.incubator.vector.
>> 
>> [regression_fixes_post_merge.txt](https://github.com/openjdk/valhalla/files/11527140/regression_fixes_post_merge.txt)
>> 
>> You may integrate it along with your patch to validate and avoid duplications,  alternatively, I can post this as a stand alone patch once merge patch is integrated, I see couple of more issues and in process of fixing them.  Will re-review and validate your shuffle/mask changes and share my comments.
>> 
>> Thanks!
>
>> Hi @jatin-bhateja ,
>> 
>> I'm sorry that I forgot to tell you that there are several fixes in this PR, which may conflict with your fixing. Could you please help to review this patch and do the testing? It will be better if this patch can be merged soon, so that we can have a whole testing and bug fixing based on it.
>> 
>> Thanks, Xiaohong
> 
> Hi @XiaohongGong ,
> I went over entire patch and added few comments, overall the patch looks good to me.
> 
> Best Regards,
> Jatin

Hi @jatin-bhateja , I'v added the assertion and FIXME in `InlineTypeNode::load()`. Could you please help to check whether it is ok? Thanks!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/845#issuecomment-1566637693