RFR: 8338910: [lw5] enhance the Signature attribute to represent nullability [v3]

Vicente Romero vromero at openjdk.org
Thu Aug 29 22:45:06 UTC 2024


On Thu, 29 Aug 2024 22:42:18 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Enhance the Signature attribute so that we can represent nullability and null restrictions
>
> Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - erasure was not removing nullness markers
>  - changes to NullRestricted parsing
>  - change to SignaturesImpl
>  - addressing review comments
>  - fixing bugs
>  - adding test case
>  - removing commented code
>  - Merge with lw5
>  - fixing bugs
>  - array support, addressing review comments
>  - ... and 2 more: https://git.openjdk.org/valhalla/compare/4999dfe1...07a53fe5

src/java.base/share/classes/jdk/internal/classfile/impl/SignaturesImpl.java line 136:

> 134:     private RefTypeSig referenceTypeSig() {
> 135:         return switch (sig.charAt(sigp)) {
> 136:             case 'L' : classTypeSig();

should be `case 'L' : yield classTypeSig();` fixed in my local repo

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1223#discussion_r1731627402


More information about the valhalla-dev mailing list