RFR: 8338910: [lw5] enhance the Signature attribute to represent nullability [v3]

[Maurizio Cimadamore]

On Thu, 29 Aug 2024 22:42:18 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Enhance the Signature attribute so that we can represent nullability and null restrictions
>
> Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - erasure was not removing nullness markers
>  - changes to NullRestricted parsing
>  - change to SignaturesImpl
>  - addressing review comments
>  - fixing bugs
>  - adding test case
>  - removing commented code
>  - Merge with lw5
>  - fixing bugs
>  - array support, addressing review comments
>  - ... and 2 more: https://git.openjdk.org/valhalla/compare/4999dfe1...07a53fe5

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 409:

> 407:             } else {
> 408:                 for (Type param : t.allparams()) {
> 409:                     if (param.getNullMarker() != NullMarker.UNSPECIFIED) {

we should probably just delegate here?

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 439:

> 437: 
> 438:         @Override
> 439:         public Boolean visitCapturedType(CapturedType t, Set<Type> seen) {

This can't be in a signature

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1223#discussion_r1736275899
PR Review Comment: https://git.openjdk.org/valhalla/pull/1223#discussion_r1736274368