[lworld] RFR: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Jul 19 20:40:48 UTC 2024


On Fri, 19 Jul 2024 16:48:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The test uses the class file reconstituter to provide the redefined bytecodes, leaving out the LoadableDescriptors.  Adding them to the reconsistituted class file makes the test pass, also fix the verification code since these descriptors are utf8s now.  Tested with java/lang/instrument with --enable-preview.  Should write a test but I don't know how, and the code is already tested with permitted subclasses and other attributes.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add back the oxford comma.

Thanks Fred and Dan.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1172#issuecomment-2240069297


More information about the valhalla-dev mailing list