[lworld] RFR: 8336682: [lworld] java/lang/instrument/IsModifiableClassAgent.java test fails when run with migrates classes [v3]
duke
duke at openjdk.org
Fri Jul 19 20:40:48 UTC 2024
On Fri, 19 Jul 2024 16:48:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> The test uses the class file reconstituter to provide the redefined bytecodes, leaving out the LoadableDescriptors. Adding them to the reconsistituted class file makes the test pass, also fix the verification code since these descriptors are utf8s now. Tested with java/lang/instrument with --enable-preview. Should write a test but I don't know how, and the code is already tested with permitted subclasses and other attributes.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Add back the oxford comma.
@coleenp
Your change (at version 7665d5b3a5f11d1d96dc966b01a7bc1eebbf7ef7) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1172#issuecomment-2240070499
More information about the valhalla-dev
mailing list