[lworld] RFR: 8329108: [lworld] valhalla/valuetypes/ObjectMethods.java fails with default CDS archive

[Frederic Parain]

On Wed, 24 Jul 2024 21:14:14 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> When this test was run after `java -Xshare:dump --enable-preview`, the test would crash due to a null signature calling convention. This occurred because `has_scalarized_args`, a flag whose value should be determined at runtime when regenerating the method adapter, was stored in ConstMethod and then archived. The resulting mismatch in a subsequent run meant the wrong `sig_cc` would be used. This change moves the flags in question into `method.hpp` and avoids dumping them so they can be properly regenerated at runtime. The test was verified locally and the changes were further verified with tier 1-5 tests.

LGTM
Thank you for the investigation you did on this bug.

-------------

Marked as reviewed by fparain (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1180#pullrequestreview-2199955557