[lworld] RFR: 8329108: [lworld] valhalla/valuetypes/ObjectMethods.java fails with default CDS archive
Matias Saavedra Silva
matsaave at openjdk.org
Thu Jul 25 17:39:00 UTC 2024
On Thu, 25 Jul 2024 17:20:11 GMT, David Simms <dsimms at openjdk.org> wrote:
>> When this test was run after `java -Xshare:dump --enable-preview`, the test would crash due to a null signature calling convention. This occurred because `has_scalarized_args`, a flag whose value should be determined at runtime when regenerating the method adapter, was stored in ConstMethod and then archived. The resulting mismatch in a subsequent run meant the wrong `sig_cc` would be used. This change moves the flags in question into `method.hpp` and avoids dumping them so they can be properly regenerated at runtime. The test was verified locally and the changes were further verified with tier 1-5 tests.
>
> LGTM
Thanks for the reviews @MrSimms and @fparain!
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1180#issuecomment-2251045823
More information about the valhalla-dev
mailing list