[lworld+fp16] RFR: 8329817: Augment prototype Float16 class
Joe Darcy
darcy at openjdk.org
Fri Jun 7 18:30:23 UTC 2024
On Fri, 7 Jun 2024 09:38:20 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Sketch of a more full-featured API for Float16.
>
> src/java.base/share/classes/java/lang/Float16.java line 60:
>
>> 58: // Currently Float16 is a primitive class but in future will be aligned with
>> 59: // Enhanced Primitive Boxes described by JEP-402 (https://openjdk.org/jeps/402)
>> 60: public /*primitive*/ class Float16 extends Number
>
> Shouldn't this be attributed with jdk.internal.ValueBased annotation like other primitive boxes to facilitate creation of an InlineKlass for it.
I don't know the proper idiom for that use. (I commented out the "primitive" modifier so I could get the doc build to work for the class.)
Do you know what the plans are for syncing in changes from Valhalla mainline into lworld+fp16?
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1631559537
More information about the valhalla-dev
mailing list