[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v2]

[Jatin Bhateja]

On Fri, 7 Jun 2024 18:27:16 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/Float16.java line 60:
>> 
>>> 58: // Currently Float16 is a primitive class but in future will be aligned with
>>> 59: // Enhanced Primitive Boxes described by JEP-402 (https://openjdk.org/jeps/402)
>>> 60: public /*primitive*/ class Float16 extends Number
>> 
>> Shouldn't this be attributed with jdk.internal.ValueBased annotation like other primitive boxes to facilitate creation of an InlineKlass for it.
>
> I don't know the proper idiom for that use. (I commented out the "primitive" modifier so I could get the doc build to work for the class.)
> 
> Do you know what the plans are for syncing in changes from Valhalla mainline into lworld+fp16?

Hi @jddarcy , I have just integrated a [merge pull request](https://github.com/openjdk/valhalla/pull/1120) to merge latest lworld code into lworld+fp16. With this I made Floar16 an implicitly constructible value based class in order to facilitate flat layout representation for Float16 arrays.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1632374099