[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v3]
Joe Darcy
darcy at openjdk.org
Mon Jun 10 16:53:00 UTC 2024
On Sun, 9 Jun 2024 19:16:23 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> I don't know the proper idiom for that use. (I commented out the "primitive" modifier so I could get the doc build to work for the class.)
>>
>> Do you know what the plans are for syncing in changes from Valhalla mainline into lworld+fp16?
>
> Hi @jddarcy , I have just integrated a [merge pull request](https://github.com/openjdk/valhalla/pull/1120) to merge latest lworld code into lworld+fp16. With this I made Floar16 an implicitly constructible value based class in order to facilitate[ flat layout representation](https://github.com/openjdk/valhalla/blob/lworld%2Bfp16/src/hotspot/share/interpreter/interpreterRuntime.cpp#L383) for Float16 arrays.
>
> Please note that ImplicitlyConstructible annotation was enforced on generated source of Float16 value based class.
Thanks @jatin-bhateja . I merged in the changes and updated the Float16 tests to pass.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1633550870
More information about the valhalla-dev
mailing list