[lworld] RFR: 8333757: [lworld] sync javac code generation with the latest spec [v3]

Chen Liang liach at openjdk.org
Tue Jun 11 00:16:31 UTC 2024


On Mon, 10 Jun 2024 23:31:58 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Renaming the Preload attribute plus changing its contents. Side-effects, changes to class file API, javap,etc
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   do not include arrays in the LoadableDescriptors attribute in InnerClassLambdaMetafactory, plus some refacts

src/java.base/share/classes/java/lang/classfile/attribute/LoadableDescriptorsAttribute.java line 68:

> 66:      * @param loadableDescriptors the loadable descriptors
> 67:      */
> 68:     static LoadableDescriptorsAttribute of(Utf8Entry... loadableDescriptors) {

I recommend another set of factory:

static LoadableDescriptorsAttribute ofSymbols(ClassDesc... loadableDescriptors);
static LoadableDescriptorsAttribute ofSymbols(List<ClassDesc> loadableDescriptors);

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1118#discussion_r1633997242



More information about the valhalla-dev mailing list