[lworld] RFR: 8333757: [lworld] sync javac code generation with the latest spec [v3]

[Vicente Romero]

On Tue, 11 Jun 2024 00:11:13 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   do not include arrays in the LoadableDescriptors attribute in InnerClassLambdaMetafactory, plus some refacts
>
> src/java.base/share/classes/java/lang/classfile/attribute/LoadableDescriptorsAttribute.java line 68:
> 
>> 66:      * @param loadableDescriptors the loadable descriptors
>> 67:      */
>> 68:     static LoadableDescriptorsAttribute of(Utf8Entry... loadableDescriptors) {
> 
> I recommend another set of factory:
> 
> static LoadableDescriptorsAttribute ofSymbols(ClassDesc... loadableDescriptors);
> static LoadableDescriptorsAttribute ofSymbols(List<ClassDesc> loadableDescriptors);

I don't see the benefit tbh

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1118#discussion_r1634935661