[lworld] RFR: 8333757: [lworld] sync javac code generation with the latest spec [v3]

[Chen Liang]

On Tue, 11 Jun 2024 13:53:33 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/classfile/attribute/LoadableDescriptorsAttribute.java line 68:
>> 
>>> 66:      * @param loadableDescriptors the loadable descriptors
>>> 67:      */
>>> 68:     static LoadableDescriptorsAttribute of(Utf8Entry... loadableDescriptors) {
>> 
>> I recommend another set of factory:
>> 
>> static LoadableDescriptorsAttribute ofSymbols(ClassDesc... loadableDescriptors);
>> static LoadableDescriptorsAttribute ofSymbols(List<ClassDesc> loadableDescriptors);
>
> I don't see the benefit tbh

Indeed, this is mostly useful for things like lambda gen once JDK moves such gen to CF API.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1118#discussion_r1635150510