[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v6]

[Jatin Bhateja]

On Wed, 12 Jun 2024 02:52:02 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Sketch of a more full-featured API for Float16.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added 2p+2 comment, fma disclaimer, etc.

Hi @jddarcy , Apart from few minor comments, patch looks good to me, there is a build error due to malformed javadoc comment. 

Kindly fix and integrate.

src/java.base/share/classes/java/lang/Float16.java line 63:

> 61:  * of equivalent cases by methods in {@code Float}, {@code Double},
> 62:  * {@code Math}, etc.
> 63:  *

May I kindly request you to please append your name to file @author list.

src/java.base/share/classes/java/lang/Float16.java line 616:

> 614:      * @see java.util.function.BinaryOperator
> 615:      * @see Math.max(float, float)
> 616:      * @see Math.max(double, double)

Suggestion:

     * @see Math#max(float, float)
     * @see Math#max(double, double)

src/java.base/share/classes/java/lang/Float16.java line 635:

> 633:      * @see java.util.function.BinaryOperator
> 634:      * @see Math.min(float, float)
> 635:      * @see Math.min(double, double)

Suggestion:

     * @see Math#min(float, float)
     * @see Math#min(double, double)

src/java.base/share/classes/java/lang/Float16.java line 888:

> 886:      * the last place, of a {@code Float16} value is the positive
> 887:      * distance between this floating-point value and the {@code
> 888:      * double} value next larger in magnitude.  Note that for non-NaN

Suggestion:

     * Float16} value next larger in magnitude.  Note that for non-NaN

-------------

Marked as reviewed by jbhateja (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1117#pullrequestreview-2112773122
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1636319783
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1636313611
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1636313079
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1636411997