[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v6]

Joe Darcy darcy at openjdk.org
Wed Jun 12 20:52:27 UTC 2024


On Wed, 12 Jun 2024 11:45:53 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added 2p+2 comment, fma disclaimer, etc.
>
> src/java.base/share/classes/java/lang/Float16.java line 63:
> 
>> 61:  * of equivalent cases by methods in {@code Float}, {@code Double},
>> 62:  * {@code Math}, etc.
>> 63:  *
> 
> May I kindly request you to please append your name to file @author list.

In the mainline JDK, we've long since stopped adding new `@author` tags. (I've actually removed some of my `@author` tags in some test code.) In preparation for a future where Float16 is in the mainline JDK, I suggest this information be recorded in some other fashion, at least when integrated into the mainline.

The `/contributor ` Skara command can be used to record multiple co-authors of the code in a PR. That is one way this information could be preserved when integrated into the mainline.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1637069837



More information about the valhalla-dev mailing list