[lworld+fp16] RFR: 8329817: Augment prototype Float16 class [v6]
Joe Darcy
darcy at openjdk.org
Fri Jun 14 06:07:23 UTC 2024
On Wed, 12 Jun 2024 11:45:53 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added 2p+2 comment, fma disclaimer, etc.
>
> src/java.base/share/classes/java/lang/Float16.java line 63:
>
>> 61: * of equivalent cases by methods in {@code Float}, {@code Double},
>> 62: * {@code Math}, etc.
>> 63: *
>
> May I kindly request you to please append your name to file @author list.
Hi @jatin-bhateja,
With the latest commit, I think the spec is close to the spec that would be acceptable to include in mainline. Please confirm you're okay with this state of the PR being integrated. Afterward, work can continue refining a few areas binary <-> decimal spec and implementation, fma internal comment and/or implementation, etc. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1117#discussion_r1639307670
More information about the valhalla-dev
mailing list