[lworld] RFR: 8282106: [lworld] IdentityException should identify the value class [v2]

Roger Riggs rriggs at openjdk.org
Fri Jun 28 14:45:27 UTC 2024


On Fri, 28 Jun 2024 12:56:56 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Improve the message of IdentityException by including the class of the instance that triggered the exception.
>
> Frederic Parain has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix indentation
>  - Add aarch64 support

test/hotspot/jtreg/runtime/valhalla/inlinetypes/MonitorEnterTest.java line 29:

> 27: * @enablePreview
> 28: * @compile TestCloneableValue.java
> 29: * @run main/othervm -XX:LockingMode=0 runtime.valhalla.inlinetypes.TestCloneableValue

I'm missing the connection between TestCloneableValue and MonitorEnterTest?
Should the @run line refer to MonitorEnterTest.MyValue?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1150#discussion_r1658864680


More information about the valhalla-dev mailing list