[lworld] RFR: 8282106: [lworld] IdentityException should identify the value class [v2]

[Frederic Parain]

On Fri, 28 Jun 2024 14:43:09 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix indentation
>>  - Add aarch64 support
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/MonitorEnterTest.java line 29:
> 
>> 27: * @enablePreview
>> 28: * @compile TestCloneableValue.java
>> 29: * @run main/othervm -XX:LockingMode=0 runtime.valhalla.inlinetypes.TestCloneableValue
> 
> I'm missing the connection between TestCloneableValue and MonitorEnterTest?
> Should the @run line refer to MonitorEnterTest.MyValue?

Good catch! This is not the test I used during development, but one that I wrote after, and I clearly did it too quickly.
I've pushed a fix for the test that should address this issue (and a few others in the test itself).

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1150#discussion_r1658948546