[lworld] RFR: 8327636: [lworld] Make primitive wrappers be value class if preview feature is enabled [v2]

Mandy Chung mchung at openjdk.org
Fri Mar 8 04:59:00 UTC 2024


On Fri, 8 Mar 2024 04:30:02 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed duplicated Record
>
> src/java.base/share/classes/sun/invoke/util/VerifyAccess.java line 212:
> 
>> 210: 
>> 211:             // exports are not setup during early VM initialization
>> 212:             if (!jdk.internal.misc.VM.isModuleSystemInited()) {
> 
> Should we merge this and the `lookupModule == null` early startup cases, and `assert lookupModule == refModule && refModule == Object.class.getModule()` can become `assert lookupModule == refModule && (refModule == null || refModule == Object.class.getModule())`?

It can be simpler:


            // early VM startup case, java.base not defined or module system not initialized
            if (lookupModule == null || !jdk.internal.misc.VM.isModuleSystemInited()) {
                assert lookupModule == refModule;
                return true;
            }

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1040#discussion_r1517165488



More information about the valhalla-dev mailing list