[lworld] RFR: 8327636: [lworld] Make primitive wrappers be value class if preview feature is enabled [v2]
Chen Liang
liach at openjdk.org
Fri Mar 8 05:05:58 UTC 2024
On Fri, 8 Mar 2024 04:56:15 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> src/java.base/share/classes/sun/invoke/util/VerifyAccess.java line 212:
>>
>>> 210:
>>> 211: // exports are not setup during early VM initialization
>>> 212: if (!jdk.internal.misc.VM.isModuleSystemInited()) {
>>
>> Should we merge this and the `lookupModule == null` early startup cases, and `assert lookupModule == refModule && refModule == Object.class.getModule()` can become `assert lookupModule == refModule && (refModule == null || refModule == Object.class.getModule())`?
>
> It can be simpler:
>
>
> // early VM startup case, java.base not defined or module system not initialized
> if (lookupModule == null || !jdk.internal.misc.VM.isModuleSystemInited()) {
> assert lookupModule == refModule;
> return true;
> }
Can `Class::getModule` ever return `null` after module system is initialized? If not we can omit the `lookupModule == null` check.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1040#discussion_r1517169212
More information about the valhalla-dev
mailing list