[lworld] RFR: 8328150: [lworld] Adjust flags to "--enable-preview" clear out EnableValhalla and EnablePrimitiveClasses

Frederic Parain fparain at openjdk.org
Tue Mar 19 14:57:30 UTC 2024


On Tue, 19 Mar 2024 10:23:23 GMT, David Simms <dsimms at openjdk.org> wrote:

> * Removed all cases of -XX: EnableValhalla and EnablePrimitiveClasses
> * Deleted tests that were dominated by now defunct concepts (withfield, entirely primitives classes etc)
> * Trival fixes to simply remove primitive class tests cases
> * `@ignores` tagged with bug number where tests need non-trival updating to JEP401 concepts

Thank you for this huge cleanup.
Would it make sense to also clean the modules export options?
Many tests use "--add-exports java.base/jdk.internal.vm.annotation=ALL-UNNAMED --add-exports java.base/jdk.internal.value=ALL-UNNAMED" and those options have to be copied on build, compile, and run commands.
We could let JTREG add those options itself by just adding this to the JTREG tags:

 * @modules java.base/jdk.internal.vm.annotation
 *          java.base/jdk.internal.classfile
 ```

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1052#issuecomment-2007393930



More information about the valhalla-dev mailing list