[lworld] RFR: 8328150: [lworld] Adjust flags to "--enable-preview" clear out EnableValhalla and EnablePrimitiveClasses

David Simms dsimms at openjdk.org
Tue Mar 19 15:21:36 UTC 2024


On Tue, 19 Mar 2024 14:52:53 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Thank you for this huge cleanup. Would it make sense to also clean the modules export options? Many tests use "--add-exports java.base/jdk.internal.vm.annotation=ALL-UNNAMED --add-exports java.base/jdk.internal.value=ALL-UNNAMED" and those options have to be copied on build, compile, and run commands. We could let JTREG add those options itself by just adding this to the JTREG tags:
> 
> ```
>  * @modules java.base/jdk.internal.vm.annotation
>  *          java.base/jdk.internal.classfile
> ```

Totally, good call, let me make another pass

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1052#issuecomment-2007472390



More information about the valhalla-dev mailing list