[lworld+fp16] RFR: 8338061: Add support for FP16 unary and ternary operations [v2]

Bhavana Kilambi bkilambi at openjdk.org
Tue Sep 3 11:22:38 UTC 2024


On Tue, 20 Aug 2024 08:59:56 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Address review comments
>>  - Merge branch 'lworld+fp16'
>>  - 8338061: Add support for FP16 unary and ternary operations
>>    
>>    This patch adds support for three unary operators - abs, neg and sqrt
>>    and a ternary operator - fma for FP16.
>>    Both scalar and vector mid-end support along with aarch64 backend
>>    support are added.
>>    Tested all FP16 tests successfully on aarch64.
>
> Looks good to me, apart from one test comment.

Hi @jatin-bhateja , did you get a chance to go through my patch? Thanks!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1211#issuecomment-2326267136


More information about the valhalla-dev mailing list