[lworld+fp16] RFR: 8338061: Add support for FP16 unary and ternary operations [v2]

[Jatin Bhateja]

On Tue, 20 Aug 2024 08:59:56 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Address review comments
>>  - Merge branch 'lworld+fp16'
>>  - 8338061: Add support for FP16 unary and ternary operations
>>    
>>    This patch adds support for three unary operators - abs, neg and sqrt
>>    and a ternary operator - fma for FP16.
>>    Both scalar and vector mid-end support along with aarch64 backend
>>    support are added.
>>    Tested all FP16 tests successfully on aarch64.
>
> Looks good to me, apart from one test comment.

> Hi @jatin-bhateja , I have addressed review comments. Please take a look. Also, I have noticed that after the recent merge with `lworld` , the vector tests - `compiler/vectorization/TestFloat16VectorOps.java` and `compiler/vectorization/TestFloat16VectorReinterpretConv.java` failed. Looks like none of the FP16 operations are getting vectorized either. Any idea why? Initially I suspected if any of the code from this patch - [#1154 (comment)](https://github.com/openjdk/valhalla/pull/1154#issuecomment-2208350696) got botched up during the merge but it looks like all of that code is fine and the test to test flat array vectorization - `test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestFlatArrayVectorization.java` also passes.

Hi @Bhavana-Kilambi, I am working on fixing this at priority, @rgiulietti also faced problems in running the automated tests and pointed out the issue with multiple occurrence of libLinkerInvokerUnnamed.cpp.

Will address both these issues.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1211#issuecomment-2327878606