[lworld+fp16] RFR: 8338061: Add support for FP16 unary and ternary operations [v2]
Jatin Bhateja
jbhateja at openjdk.org
Wed Sep 4 15:31:38 UTC 2024
On Tue, 27 Aug 2024 15:44:03 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:
>> This patch adds support for three unary operators - abs, neg and sqrt and a ternary operator - fma for FP16.
>> Both scalar and vector mid-end support along with aarch64 backend support are added.
>> Tested all FP16 tests successfully on aarch64.
>
> Bhavana Kilambi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Address review comments
> - Merge branch 'lworld+fp16'
> - 8338061: Add support for FP16 unary and ternary operations
>
> This patch adds support for three unary operators - abs, neg and sqrt
> and a ternary operator - fma for FP16.
> Both scalar and vector mid-end support along with aarch64 backend
> support are added.
> Tested all FP16 tests successfully on aarch64.
Hi @Bhavana-Kilambi , Patch looks good to me, I did a merge and fixed the failing regressions. Kindly rebase and submit the patch, I will add x86 backed support for these new operations.
Best Regards,
Jatin
-------------
Marked as reviewed by jbhateja (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1211#pullrequestreview-2280575060
More information about the valhalla-dev
mailing list