[lworld+fp16] RFR: 8338061: Add support for FP16 unary and ternary operations [v3]

Bhavana Kilambi bkilambi at openjdk.org
Thu Sep 5 12:15:00 UTC 2024


On Wed, 4 Sep 2024 04:15:33 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Looks good to me, apart from one test comment.
>
>> Hi @jatin-bhateja , I have addressed review comments. Please take a look. Also, I have noticed that after the recent merge with `lworld` , the vector tests - `compiler/vectorization/TestFloat16VectorOps.java` and `compiler/vectorization/TestFloat16VectorReinterpretConv.java` failed. Looks like none of the FP16 operations are getting vectorized either. Any idea why? Initially I suspected if any of the code from this patch - [#1154 (comment)](https://github.com/openjdk/valhalla/pull/1154#issuecomment-2208350696) got botched up during the merge but it looks like all of that code is fine and the test to test flat array vectorization - `test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestFlatArrayVectorization.java` also passes.
> 
> Hi @Bhavana-Kilambi, I am working on fixing this at priority, @rgiulietti also faced problems in running the automated tests and pointed out the issue with multiple occurrence of libLinkerInvokerUnnamed.cpp.
> 
> Will address both these issues.

Hi @jatin-bhateja , I have rebased my patch. Thanks for the approval. Could you please sponsor?

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1211#issuecomment-2331358666


More information about the valhalla-dev mailing list