[lworld] RFR: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics [v2]

Quan Anh Mai qamai at openjdk.org
Wed Apr 2 06:27:30 UTC 2025


On Tue, 1 Apr 2025 05:42:46 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> I filed https://bugs.openjdk.org/browse/JDK-8353236 for improving the javadoc and I will file another issue later to try our best catching the illegal uses in C2.
>
> Hi @merykitty , 
> Thanks for clearly spelling out the UNSAFE API semantics it chops out ambiguities about
> context in which larval values can be used.
> 
> The approach looks correct to me and aligns with larval handling in lworld+vector.
> 
> I see you have not addressed some minor comments around comments reformatting, 
> Should we include the crash test in this PR  and add it to ProblemList.txt for now?
> 
> https://github.com/user-attachments/files/19501609/unsafe_access.txt
> 
> Best Regards,
> Jatin

Thank @jatin-bhateja for the reviews and profound discussion.

@TobiHartmann Do I need to wait for you to run some tests?

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1406#issuecomment-2771454201


More information about the valhalla-dev mailing list