[lworld] RFR: 8352647: [lworld] Remove larval InlineTypeNode in Unsafe intrinsics [v2]
Tobias Hartmann
thartmann at openjdk.org
Wed Apr 2 13:31:13 UTC 2025
On Wed, 2 Apr 2025 06:24:27 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Hi @merykitty ,
>> Thanks for clearly spelling out the UNSAFE API semantics it chops out ambiguities about
>> context in which larval values can be used.
>>
>> The approach looks correct to me and aligns with larval handling in lworld+vector.
>>
>> I see you have not addressed some minor comments around comments reformatting,
>> Should we include the crash test in this PR and add it to ProblemList.txt for now?
>>
>> https://github.com/user-attachments/files/19501609/unsafe_access.txt
>>
>> Best Regards,
>> Jatin
>
> Thank @jatin-bhateja for the reviews and profound discussion.
>
> @TobiHartmann Do I need to wait for you to run some tests?
Thanks for asking, @merykitty. I'll run some testing and will report back.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1406#issuecomment-2772570054
More information about the valhalla-dev
mailing list