[lworld] Integrated: 8353639: [lworld] IGV: Fix broken type info filter with TypeAryPtr::_field_offset

Tobias Hartmann thartmann at openjdk.org
Thu Apr 3 12:29:36 UTC 2025


On Thu, 3 Apr 2025 12:19:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The `TypeAryPtr::_field_offset` information is dumped inside a pair of braces:
> 
>                                                          --> HERE <--
> flat:narrowoop: V1:NotNull:exact *[int:≥0]:NotNull:exact:flat(+4):null_free[2] * [narrow]
> 
> The problem is that the type info filter from mainline only expects that interface types are found inside braces and then tries to remove them. This now messes with two pair of braces.
> 
> The fix I propose is to match anything but the first closing `)` when finding the first `(` with `([^)]*)` for the interface types instead of matching it with `(.*)` which matches up to the field offset.
> 
> Without fix:
> ![Screenshot from 2025-04-03 13-57-20](https://github.com/user-attachments/assets/3baf40df-2ea4-4b7d-a450-6dca200b986f)
> 
> With fix:
> ![Screenshot from 2025-04-03 13-59-20](https://github.com/user-attachments/assets/a5c97f9e-cd70-4f81-af85-5bd8c960f4aa)
> 
> Thanks,
> Christian

Good catch, looks good!

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1414#pullrequestreview-2739658807


More information about the valhalla-dev mailing list