[lworld] Integrated: 8353639: [lworld] IGV: Fix broken type info filter with TypeAryPtr::_field_offset
Christian Hagedorn
chagedorn at openjdk.org
Thu Apr 3 12:29:36 UTC 2025
On Thu, 3 Apr 2025 12:19:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
> The `TypeAryPtr::_field_offset` information is dumped inside a pair of braces:
>
> --> HERE <--
> flat:narrowoop: V1:NotNull:exact *[int:≥0]:NotNull:exact:flat(+4):null_free[2] * [narrow]
>
> The problem is that the type info filter from mainline only expects that interface types are found inside braces and then tries to remove them. This now messes with two pair of braces.
>
> The fix I propose is to match anything but the first closing `)` when finding the first `(` with `([^)]*)` for the interface types instead of matching it with `(.*)` which matches up to the field offset.
>
> Without fix:
> 
>
> With fix:
> 
>
> Thanks,
> Christian
Thanks Tobias for your quick review!
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1414#issuecomment-2775621153
More information about the valhalla-dev
mailing list