[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest

Chen Liang liach at openjdk.org
Wed Apr 16 02:03:59 UTC 2025


On Wed, 16 Apr 2025 01:27:56 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> The updates to the core libraries + langtools for the latest strict field initialization spec https://cr.openjdk.org/~dlsmith/jep401/jep401-20250409/specs/strict-fields-jvms.html is ready.
>> 
>> Currently, since there is no VM support, testing is restricted to generation by ClassFile API/javac and inspection through ClassFile API (and javap)
>> 
>> Not suitable for integration yet; StrictFinalInstanceFieldsTest requires VM side's support.
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java line 299:
> 
>> 297:                 }
>> 298:             }
>> 299:             if (actualFrameType != 247 && !unsetFields.isEmpty() && !locals.contains(SimpleVerificationTypeInfo.UNINITIALIZED_THIS)) {
> 
> we should use a constant not a literal, 247, here

Very true, this literal is also wrong

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2045861478


More information about the valhalla-dev mailing list