[lworld] RFR: 8354728: [lworld] Langtools work to update strict implementation to latest [v2]

[Chen Liang]

On Wed, 16 Apr 2025 00:52:21 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestions, also rollback the getEntryType rename in javac, test updates
>
> src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java line 301:
> 
>> 299:                         continue;
>> 300:                     }
>> 301:                     case 247 -> {
> 
> side: in some classes we use constants for the frame types here we are using literals, we probably should use the same approach always, this is not related to the PR but could be fixed in a separate issue

Created https://bugs.openjdk.org/browse/JDK-8354871 to track this RFE.

> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java line 178:
> 
>> 176:         if (offsetDelta < 0) throw new IllegalArgumentException("Invalid stack map frames order");
>> 177:         // enclosing frames
>> 178:         writeLarvalFrame:
> 
> not a big fan of using labels, I wonder if the code can be refactored to avoid using them

Yep, factored these out to methods with extra asserts, does look cleaner

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2047206880
PR Review Comment: https://git.openjdk.org/valhalla/pull/1432#discussion_r2047207557