[lworld] RFR: 8354068: [lworld] Fold strict final fields more aggressively [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Apr 23 19:03:03 UTC 2025


On Wed, 23 Apr 2025 13:15:17 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix wrong results
>>  - fix invalid node class: Unlock
>
> src/hotspot/share/opto/memnode.cpp line 257:
> 
>> 255:   assert(t_oop != nullptr, "sanity");
>> 256:   bool is_instance = t_oop->is_known_instance_field();
>> 257: 
> 
> What about the `is_boxed_value_load`? If Valhalla / preview is disabled, these wouldn't be covered by `is_strict_final_load` right?

I also wonder if the other usages of `is_ptr_to_boxed_value()` in the code could need some update.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1424#discussion_r2056213104


More information about the valhalla-dev mailing list