[lworld] RFR: 8354068: [lworld] Fold strict final fields more aggressively [v2]

Quan Anh Mai qamai at openjdk.org
Thu Apr 24 01:19:48 UTC 2025


On Wed, 23 Apr 2025 14:36:34 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> src/hotspot/share/opto/memnode.cpp line 257:
>> 
>>> 255:   assert(t_oop != nullptr, "sanity");
>>> 256:   bool is_instance = t_oop->is_known_instance_field();
>>> 257: 
>> 
>> What about the `is_boxed_value_load`? If Valhalla / preview is disabled, these wouldn't be covered by `is_strict_final_load` right?
>
> I also wonder if the other usages of `is_ptr_to_boxed_value()` in the code could need some update.

That's right, I have added a case when valhalla is not enabled to catch `is_ptr_to_boxed_value` then.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1424#discussion_r2057149416


More information about the valhalla-dev mailing list